[PATCH] D21393: [pdbdump] Verify LF_{CLASS, ENUM, INTERFACE, STRUCTURE, UNION} records with different hash function.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 11:33:02 PDT 2016


ruiu added a comment.

It may work (though I didn't try), but I think the current structure is better since we are going to remove this code from here and add code to actually generate hash values to the writer. In the current structure, the code to generate hash values are separated and concentrated. It's better than scatter it into multiple methods.


http://reviews.llvm.org/D21393





More information about the llvm-commits mailing list