[PATCH] D18586: Allow DeadStoreElimination to track combinations of partial later wrties

[Hal Finkel via llvm-commits]

hfinkel added inline comments.

================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:406
@@ +405,3 @@
+      LaterIntStart = std::min(LaterIntStart, ILI->second);
+      ILI = IM.erase(ILI);
+
----------------
junbuml wrote:
> Don't you need to do :
>    LaterIntEnd = std::max(LaterIntEnd, ILI->first); 
> before erasing ILI in case ILI->first is larger than LaterIntEnd ?
> 
> 
> 
Thanks for catching that.

================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:413
@@ +412,3 @@
+        LaterIntEnd = std::max(LaterIntEnd, ILI->first);
+        ILI = IM.erase(ILI);
+      }
----------------
junbuml wrote:
> I think there is no need to assign to ILI here.
Indeed.


http://reviews.llvm.org/D18586