[PATCH] D18586: Allow DeadStoreElimination to track combinations of partial later wrties
Jun Bum Lim via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 16 11:01:25 PDT 2016
junbuml added inline comments.
================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:406
@@ +405,3 @@
+ LaterIntStart = std::min(LaterIntStart, ILI->second);
+ ILI = IM.erase(ILI);
+
----------------
Don't you need to do :
LaterIntEnd = std::max(LaterIntEnd, ILI->first);
before erasing ILI in case ILI->first is larger than LaterIntEnd ?
================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:413
@@ +412,3 @@
+ LaterIntEnd = std::max(LaterIntEnd, ILI->first);
+ ILI = IM.erase(ILI);
+ }
----------------
I think there is no need to assign to ILI here.
http://reviews.llvm.org/D18586
More information about the llvm-commits
mailing list