[PATCH] D21125: [llvm-objdump] Support detection of feature bits from the object and implement this for Mips.

[Daniel Sanders via llvm-commits]

> Sounds reasonable, but why not return a SubtargetFeatures?

I just didn't think of it. I've updated the patch to return SubtargetFeatures.

________________________________
From: Rafael Espíndola [rafael.espindola at gmail.com]
Sent: 13 June 2016 21:55
To: reviews+D21125+public+bc090f0c3026a427 at reviews.llvm.org; Daniel Sanders
Cc: llvm-commits; filcab+llvm.phabricator at gmail.com; Eric Christopher
Subject: Re: [PATCH] D21125: [llvm-objdump] Support detection of feature bits from the object and implement this for Mips.


Sounds reasonable, but why not return a SubtargetFeatures?

dsanders created this revision.
dsanders added a subscriber: llvm-commits.
Herald added subscribers: sdardis, dsanders.

The Mips implementation only covers the feature bits described by the ELF
e_flags so far. Mips stores additional feature bits such as MSA in the
.MIPS.abiflags section.

Also fixed a small bug this revealed where microMIPS wouldn't add the
EF_MIPS_MICROMIPS flag when using -filetype=obj.

http://reviews.llvm.org/D21125

Files:
  include/llvm/Object/COFF.h
  include/llvm/Object/ELFObjectFile.h
  include/llvm/Object/MachO.h
  include/llvm/Object/ObjectFile.h
  include/llvm/Support/ELF.h
  lib/Target/Mips/MipsAsmPrinter.cpp
  test/CodeGen/Mips/Fast-ISel/shift.ll
  test/CodeGen/Mips/compactbranches/no-beqzc-bnezc.ll
  test/CodeGen/Mips/micromips-atomic1.ll
  test/MC/Mips/cpload.s
  test/MC/Mips/cprestore-noreorder-noat.s
  test/MC/Mips/cprestore-noreorder.s
  test/MC/Mips/cprestore-reorder.s
  test/MC/Mips/cpsetup.s
  test/MC/Mips/micromips-el-fixup-data.s
  test/MC/Mips/mips64extins.s
  test/MC/Mips/mips_gprel16.s
  test/MC/Mips/set-defined-symbol.s
  test/Object/Mips/feature.test
  test/Object/Mips/objdump-micro-mips.test
  tools/llvm-objdump/llvm-objdump.cpp


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160614/5af9e7e2/attachment.html>