<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">> Sounds reasonable, but why not return a SubtargetFeatures?<br>
<br>
I just didn't think of it. I've updated the patch to return SubtargetFeatures.<br>
<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF758809"><font face="Tahoma" color="#000000" size="2"><b>From:</b> Rafael Espíndola [rafael.espindola@gmail.com]<br>
<b>Sent:</b> 13 June 2016 21:55<br>
<b>To:</b> reviews+D21125+public+bc090f0c3026a427@reviews.llvm.org; Daniel Sanders<br>
<b>Cc:</b> llvm-commits; filcab+llvm.phabricator@gmail.com; Eric Christopher<br>
<b>Subject:</b> Re: [PATCH] D21125: [llvm-objdump] Support detection of feature bits from the object and implement this for Mips.<br>
</font><br>
</div>
<div></div>
<div>
<p dir="ltr">Sounds reasonable, but why not return a SubtargetFeatures?</p>
<div class="gmail_quot<blockquote class=" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
dsanders created this revision.<br>
dsanders added a subscriber: llvm-commits.<br>
Herald added subscribers: sdardis, dsanders.<br>
<br>
The Mips implementation only covers the feature bits described by the ELF<br>
e_flags so far. Mips stores additional feature bits such as MSA in the<br>
.MIPS.abiflags section.<br>
<br>
Also fixed a small bug this revealed where microMIPS wouldn't add the<br>
EF_MIPS_MICROMIPS flag when using -filetype=obj.<br>
<br>
<a href="http://reviews.llvm.org/D21125" rel="noreferrer" target="_blank">http://reviews.llvm.org/D21125</a><br>
<br>
Files:<br>
include/llvm/Object/COFF.h<br>
include/llvm/Object/ELFObjectFile.h<br>
include/llvm/Object/MachO.h<br>
include/llvm/Object/ObjectFile.h<br>
include/llvm/Support/ELF.h<br>
lib/Target/Mips/MipsAsmPrinter.cpp<br>
test/CodeGen/Mips/Fast-ISel/shift.ll<br>
test/CodeGen/Mips/compactbranches/no-beqzc-bnezc.ll<br>
test/CodeGen/Mips/micromips-atomic1.ll<br>
test/MC/Mips/cpload.s<br>
test/MC/Mips/cprestore-noreorder-noat.s<br>
test/MC/Mips/cprestore-noreorder.s<br>
test/MC/Mips/cprestore-reorder.s<br>
test/MC/Mips/cpsetup.s<br>
test/MC/Mips/micromips-el-fixup-data.s<br>
test/MC/Mips/mips64extins.s<br>
test/MC/Mips/mips_gprel16.s<br>
test/MC/Mips/set-defined-symbol.s<br>
test/Object/Mips/feature.test<br>
test/Object/Mips/objdump-micro-mips.test<br>
tools/llvm-objdump/llvm-objdump.cpp<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
</div>
</div>
</div>
</div>
</body>
</html>