[llvm] r272241 - AArch64: support the `.arch` directive in the IAS

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 10:42:33 PDT 2016


On Thu, Jun 9, 2016 at 6:57 AM, Renato Golin <renato.golin at linaro.org>
wrote:

> On 9 June 2016 at 03:56, Saleem Abdulrasool via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: compnerd
> > Date: Wed Jun  8 21:56:40 2016
> > New Revision: 272241
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=272241&view=rev
> > Log:
> > AArch64: support the `.arch` directive in the IAS
> >
> > Add support to the AArch64 IAS for the `.arch` directive.  This allows
> the
> > assembly input to use architectural functionality in part of a file.
> This is
> > used in existing code like BoringSSL.
>
> Hi Saleem,
>
> Just a comment, it would be good to separate the good tests from the
> negative tests.
>
> We just found a number of llc negative tests that were "passing"
> because of an unrelated assert, not because they were actually hitting
> the expected error message. We don't want *all* .arch tests to "pass"
> because of problems like that. :)
>

Sure, sounds like a good idea.  SVN r272408.


> cheers,
> --renato
>

-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160610/ae5b445f/attachment-0001.html>


More information about the llvm-commits mailing list