<div dir="ltr">On Thu, Jun 9, 2016 at 6:57 AM, Renato Golin <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">On 9 June 2016 at 03:56, Saleem Abdulrasool via llvm-commits<br>
<span class=""><<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: compnerd<br>
> Date: Wed Jun  8 21:56:40 2016<br>
> New Revision: 272241<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=272241&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=272241&view=rev</a><br>
> Log:<br>
> AArch64: support the `.arch` directive in the IAS<br>
><br>
> Add support to the AArch64 IAS for the `.arch` directive.  This allows the<br>
> assembly input to use architectural functionality in part of a file.  This is<br>
> used in existing code like BoringSSL.<br>
<br>
</span>Hi Saleem,<br>
<br>
Just a comment, it would be good to separate the good tests from the<br>
negative tests.<br>
<br>
We just found a number of llc negative tests that were "passing"<br>
because of an unrelated assert, not because they were actually hitting<br>
the expected error message. We don't want *all* .arch tests to "pass"<br>
because of problems like that. :)<br></blockquote><div><br></div><div>Sure, sounds like a good idea.  SVN r272408.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
cheers,<br>
--renato<br>
</blockquote></div><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>