[PATCH] D20762: AArch64: Do not test for CPUs, use SubtargetFeatures
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 9 13:07:48 PDT 2016
MatzeB added a comment.
In http://reviews.llvm.org/D20762#453433, @evandro wrote:
> Oi, Renato.
>
> I'm for discouraging the use of `Subtarget.getProcFamily()`, but I don't think that it's realistic to suppose that every instance should be replaced with a feature. The only use for now can hardly be folded into a feature. How would you envision such minutiae as features?
>
> Obrigado.
I just wanted to stress again that we really really should try to create subtarget features as much as possible (or alternatively initialize properties in initializeProperties()). The last remaining usage of getProcFamily() in isAsCheapAsAMove() smells bad to me. I just don't have a good alternative yet. It would be nice to express things there in terms of the scheduling model, but that needs some more investigation in how to that exactly.
Repository:
rL LLVM
http://reviews.llvm.org/D20762
More information about the llvm-commits
mailing list