[PATCH] D20762: AArch64: Do not test for CPUs, use SubtargetFeatures

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 09:00:38 PDT 2016


rengolin added a comment.

In http://reviews.llvm.org/D20762#453433, @evandro wrote:

> I'm for discouraging the use of `Subtarget.getProcFamily()`, but I don't think that it's realistic to suppose that every instance should be replaced with a feature.  The only use for now can hardly be folded into a feature.  How would you envision such minutiae as features?


I don't think we'll be able to (or if it's even desirable that we do), but continue discouraging its usage (by making it awkward) will move the balance towards more features, less CPU names. I think that's all we're trying to do.

Makes sense?

Flw,
--renato


Repository:
  rL LLVM

http://reviews.llvm.org/D20762





More information about the llvm-commits mailing list