[PATCH] D21155: [SystemZ] Support Compare and Traps

Marcin Koƛcielnicki via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 11:46:21 PDT 2016


koriakin added inline comments.

================
Comment at: lib/Target/SystemZ/SystemZInstrInfo.td:74
@@ +73,3 @@
+
+let isTerminator = 1, hasCtrlDep = 1, Uses = [CC] in {
+  def CondTrap : Alias<4, (outs), (ins cond4:$valid, cond4:$R1), []>;
----------------
zhanjunl wrote:
> I'm not sure why this should be marked as usesCustomInserter? The Trap instruction needed it because I needed to split the block, but CondTrap doesn't really need it since it should only have been inserted at the end of a basic block.
Whoops, that's right, my bad.


http://reviews.llvm.org/D21155





More information about the llvm-commits mailing list