[PATCH] D21155: [SystemZ] Support Compare and Traps

[Zhan Jun Liau via llvm-commits]

zhanjunl marked 6 inline comments as done.
zhanjunl added a comment.




================
Comment at: lib/Target/SystemZ/SystemZInstrInfo.td:74
@@ +73,3 @@
+
+let isTerminator = 1, hasCtrlDep = 1, Uses = [CC] in {
+  def CondTrap : Alias<4, (outs), (ins cond4:$valid, cond4:$R1), []>;
----------------
I'm not sure why this should be marked as usesCustomInserter? The Trap instruction needed it because I needed to split the block, but CondTrap doesn't really need it since it should only have been inserted at the end of a basic block.

================
Comment at: test/CodeGen/SystemZ/trap-01.ll:26
@@ +25,3 @@
+  br i1 %cmp, label %if.then, label %if.end
+
+if.then:                                          ; preds = %entry
----------------
I have no explanation for F :(


http://reviews.llvm.org/D21155