[PATCH] D21061: [ARM] Remove exit-on-error flag from test (PR27765)

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 9 07:01:02 PDT 2016


rengolin added a comment.

In http://reviews.llvm.org/D21061#452291, @rovka wrote:

> Updated the test to use something other than undef as input too. This way we can test 2 different code paths (the one for undef is a bit special because it really doesn't create a bitcast node, it just creates an undef with the type we're bitcasting to). With this change, we're testing something a bit more realistic, and the fix still seems to work.


Right, good idea. That gives me more confidence on the patch. :)

> I can't find any tests for this error on other targets. Should I try to add one at least for X86?


If you can, that'd be great. It would ease my worries about other arches.

cheers,
--renato


http://reviews.llvm.org/D21061





More information about the llvm-commits mailing list