[PATCH] D21155: [SystemZ] Support Compare and Traps

Marcin Koƛcielnicki via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 14:44:45 PDT 2016


koriakin added a comment.

Oh, and there should be MC tests for the fused compares (an assembler test and a disassembler test).

It's also worth noting that there are also two more fused ops that could be supported here: CLT and CLGT (they don't have compare-and-branch variants), though they are a bit of a mess (they have different memory operands wrt their compare equivalents), so might be out of scope for this patch.


================
Comment at: test/CodeGen/SystemZ/trap-01.ll:25
@@ +24,3 @@
+
+; Check conditional compare grande immediate and trap
+define i64 @f2(i64 signext %a) {
----------------
I'm not sure G stands for "grande", but I like it either way :) Got a good explanation for F?


http://reviews.llvm.org/D21155





More information about the llvm-commits mailing list