[PATCH] D21155: [SystemZ] Support Compare and Traps

Marcin Koƛcielnicki via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 8 14:28:04 PDT 2016


koriakin added a comment.

Oh, and remove the TODO item from lib/Target/SystemZ/README while you're at it :)


================
Comment at: lib/Target/SystemZ/SystemZAsmPrinter.cpp:435
@@ +434,3 @@
+  // of the jump instruction, which is an illegal instruction. We cannot emit a "." symbol,
+  // so create and emit a temp label before the instruction and jump to that label instead.
+  case SystemZ::Trap: {
----------------
Nit: "jump to that label" would mean an infinite loop, say "use that label" or "jump to that label + 2" instead.


http://reviews.llvm.org/D21155





More information about the llvm-commits mailing list