[PATCH] D21080: [ThinLTO/gold] Enable summary-based internalization
Mehdi AMINI via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 8 11:25:15 PDT 2016
mehdi_amini added inline comments.
================
Comment at: tools/gold/gold-plugin.cpp:1326
@@ +1325,3 @@
+ StringSet<> Internalize;
+ StringSet<> CrossReferenced;
+
----------------
Could these contain directly GUIDs?
================
Comment at: tools/gold/gold-plugin.cpp:1367
@@ -1329,1 +1366,3 @@
+ for (auto &S : CrossReferenced)
+ Internalize.erase(S.first());
----------------
Isn't there an API to subtract a set from another one?
http://reviews.llvm.org/D21080
More information about the llvm-commits
mailing list