[PATCH] D21080: [ThinLTO/gold] Enable summary-based internalization

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

(Forgot to click submit in phab)


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:534
@@ +533,3 @@
+        // recorded in the index using the original name.
+        const auto &GS = DefinedGlobals.find(GlobalValue::getGUID(OrigName));
+        assert(GS != DefinedGlobals.end());
----------------
Note: we plan to change the alias representation to https://llvm.org/bugs/show_bug.cgi?id=27866 ; which I believe will make this issue obsolete. It may even remove the need for the aliases representation in the summary (not sure what are the implications about comdats).

Also, this seems like a bug fix that could be exposed with llvm-lto, and thus be split out of this patch?


http://reviews.llvm.org/D21080