[PATCH] D21116: [profile] Hide some external symbols in InstrProfData.inc

[Sean Silva via llvm-commits]

silvas added a comment.

In http://reviews.llvm.org/D21116#451826, @davidxl wrote:

> Since InstrProfData.inc is shared across runtime and LLVM, using COMPILER_RT_VISIBILITY there directly may not be a good idea.
>
> I think we annotate those functions with a macro   INSTR_PROF_VISIBILITY which defaults to empty string.   In InstrProfilingValue.c where InstrProfData.inc is included with INSTR_PROF_COMMON_API_IMPL defined, also define
>
> #define INSTR_PROF_VISIBILITY COMPILER_RT_VISIBILITY


This sounds like the right approach.


http://reviews.llvm.org/D21116