[PATCH] D21116: [profile] Hide some external symbols in InstrProfData.inc

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 19:07:33 PDT 2016


davidxl added a comment.

Since InstrProfData.inc is shared across runtime and LLVM, using COMPILER_RT_VISIBILITY there directly may not be a good idea.

I think we annotate those functions with a macro   INSTR_PROF_VISIBILITY which defaults to empty string.   In InstrProfilingValue.c where InstrProfData.inc is included with INSTR_PROF_COMMON_API_IMPL defined, also define

#define INSTR_PROF_VISIBILITY COMPILER_RT_VISIBILITY


http://reviews.llvm.org/D21116





More information about the llvm-commits mailing list