[PATCH] D21056: [profile] in-process profile merging support Part-3

[Xinliang David Li via llvm-commits]

On Tue, Jun 7, 2016 at 11:47 AM, Vedant Kumar <vsk at apple.com> wrote:

> vsk added inline comments.
>
> ================
> Comment at: lib/profile/InstrProfilingFile.c:149
> @@ +148,3 @@
> + * dumper. With profile merging enabled, each executable as well as any of
> + * its instrumented shared libraries dump profile data into their own
> data file.
> +*/
> ----------------
> Ok
>
> ================
> Comment at: lib/profile/InstrProfilingFile.c:238
> @@ -126,2 +237,2 @@
>    lprofCurFilename.FilenamePat = FilenamePat;
>    /* Check the filename for "%p", which indicates a pid-substitution. */
> ----------------
> I think "binary-%m.profraw" could be a common pattern; moreover I don't
> see a reason to not support this. Would removing this restriction require
> adding more code to getCurFilenameLength()/getCurFilename()?
>
>
Ok -- I can relax it.

David



> ================
> Comment at: test/profile/instrprof-basic.c:18
> @@ -5,2 +17,3 @@
> +// RUN: %clang_profuse=%t.m.profdata -o - -S -emit-llvm %s | FileCheck %s
> --check-prefix=COMMON --check-prefix=MERGE
>
>  int begin(int i) {
> ----------------
> Ok
>
>
> http://reviews.llvm.org/D21056
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160607/cdd0a46b/attachment.html>