[PATCH] D21056: [profile] in-process profile merging support Part-3

[Vedant Kumar via llvm-commits]

vsk added inline comments.

================
Comment at: lib/profile/InstrProfilingFile.c:149
@@ +148,3 @@
+ * dumper. With profile merging enabled, each executable as well as any of
+ * its instrumented shared libraries dump profile data into their own data file.
+*/
----------------
Ok

================
Comment at: lib/profile/InstrProfilingFile.c:238
@@ -126,2 +237,2 @@
   lprofCurFilename.FilenamePat = FilenamePat;
   /* Check the filename for "%p", which indicates a pid-substitution. */
----------------
I think "binary-%m.profraw" could be a common pattern; moreover I don't see a reason to not support this. Would removing this restriction require adding more code to getCurFilenameLength()/getCurFilename()?

================
Comment at: test/profile/instrprof-basic.c:18
@@ -5,2 +17,3 @@
+// RUN: %clang_profuse=%t.m.profdata -o - -S -emit-llvm %s | FileCheck %s --check-prefix=COMMON --check-prefix=MERGE
 
 int begin(int i) {
----------------
Ok


http://reviews.llvm.org/D21056