[PATCH] D21039: Fix memory access local dominance function for live on entry

[George Burgess IV via llvm-commits]

george.burgess.iv added inline comments.

================
Comment at: llvm/lib/Transforms/Utils/MemorySSA.cpp:629
@@ +628,3 @@
+  // another memory access.
+  if (isLiveOnEntryDef(Dominatee))
+    return false;
----------------
george.burgess.iv wrote:
> Can we please have a check for `isLiveOnEntryDef(Dominator)`, too? `liveOnEntry` has a null BB, so I don't see things ending well if we let that through.
...Scratch the "`liveOnEntry` has a null BB, so I don't see things ending well if we let that through" bit. We do set liveOnEntry's BB to a non-null value in `getWalker()` :)

(This is what I get for not verifying the assertions that I make before I hit "reply" ;). My bad.)


Repository:
  rL LLVM

http://reviews.llvm.org/D21039