[PATCH] D21039: Fix memory access local dominance function for live on entry

[George Burgess IV via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

Thanks for the patch!

ISTM this function is a bit broken in general if `Dominator == Dominatee` (since a node technically does dominate itself). I know it's my fault, but can you add a check for that as well, please? :)

Other than that, LGTM with a comment.


================
Comment at: llvm/lib/Transforms/Utils/MemorySSA.cpp:629
@@ +628,3 @@
+  // another memory access.
+  if (isLiveOnEntryDef(Dominatee))
+    return false;
----------------
Can we please have a check for `isLiveOnEntryDef(Dominator)`, too? `liveOnEntry` has a null BB, so I don't see things ending well if we let that through.


Repository:
  rL LLVM

http://reviews.llvm.org/D21039