[PATCH] D20936: [pdb] Parse module line info

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: tools/llvm-pdbdump/llvm-pdbdump.cpp:543-549
@@ +542,9 @@
+                  DictScope DDD(P, "Line");
+                  P.printNumber("Offset", N.Offset);
+                  P.printNumber("StartLine", N.Flags & LineInfo::StartLineMask);
+                  P.printNumber("EndDelta",
+                                (N.Flags & LineInfo::EndLineDeltaMask) >>
+                                    LineInfo::EndLineDeltaShift);
+                  P.printBoolean("IsStatement",
+                                 N.Flags & LineInfo::StatementFlag);
+                }
----------------
Instead of doing this bitmashing yourself, why not construct a LineInfo from N.Flags?


http://reviews.llvm.org/D20936