[PATCH] D20936: [pdb] Parse module line info

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 16:18:59 PDT 2016


ruiu added inline comments.

================
Comment at: include/llvm/DebugInfo/CodeView/CodeView.h:16
@@ -15,1 +15,3 @@
 
+#include "llvm/Support/Endian.h"
+
----------------
Instead of adding an #include to this header, can you include it into .cpp files that actually need Endian.h?

================
Comment at: include/llvm/DebugInfo/CodeView/ModuleSubstream.h:21
@@ +20,3 @@
+
+// Corresponds to the `CV_DebugSSubsectionHeader_t` structure.
+struct ModuleSubsectionHeader {
----------------
Thank you for these comments!

================
Comment at: include/llvm/DebugInfo/CodeView/ModuleSubstream.h:40-41
@@ +39,4 @@
+  support::ulittle32_t BlockSize; // Code size of block, in bytes.
+  // LineInfo      lines[nLines];
+  // ColumnInfo    columns[nColumns];
+};
----------------
What is this?

================
Comment at: include/llvm/DebugInfo/CodeView/ModuleSubstreamVisitor.h:22
@@ +21,3 @@
+
+struct LineColumnEntry {
+  support::ulittle32_t Offset;
----------------
What does this correspond to?

================
Comment at: include/llvm/DebugInfo/CodeView/ModuleSubstreamVisitor.h:38
@@ +37,3 @@
+      return EC;
+    bool HasColumn = !!(Header->Flags & 0x1);
+    uint32_t LineInfoSize =
----------------
I don't think you need !!.

================
Comment at: lib/DebugInfo/CodeView/ModuleSubstream.cpp:11
@@ +10,3 @@
+#include "llvm/DebugInfo/CodeView/ModuleSubstream.h"
+
+#include "llvm/DebugInfo/CodeView/StreamReader.h"
----------------
Remove this blank line.


http://reviews.llvm.org/D20936





More information about the llvm-commits mailing list