[PATCH] D20769: [IPRA] Interprocedural Register Allocation

Vivek Pandya via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 06:05:55 PDT 2016


vivekvpandya added inline comments.

================
Comment at: lib/CodeGen/RegUsageInfoCollector.cpp:37
@@ +36,3 @@
+namespace llvm {
+void initializeRegUsageInfoCollectorPass(PassRegistry &);
+}
----------------
mehdi_amini wrote:
> vivekvpandya wrote:
> > mehdi_amini wrote:
> > > Doesn't this need to be in a header and be called somewhere?
> > > It's not clear to me how is this pass registered?
> > Isn't this will be called by method generated due to macroINITIALIZE_PASS_BEGIN ?
> If there is something in the macro expansion that makes you think it is called, please elaborate.
No, I look carefully at that macro it provides definition for initialize.. method but yes some where we need to call that method. Also I haven't mentioned this pass as dependency for any other pass with INITIALIZE_PASS_DEPENDENCY other wise it can call that function. Now I am also having same question as you.



http://reviews.llvm.org/D20769





More information about the llvm-commits mailing list