[PATCH] D20769: [IPRA] Interprocedural Register Allocation

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.

================
Comment at: include/llvm/CodeGen/PhysicalRegisterUsageInfo.h:30
@@ +29,3 @@
+
+class PhysicalRegisterUsageInfo : public ImmutablePass {
+  virtual void anchor();
----------------
git clang-format takes a commit range, so you can format patches that are already committed.
(i.e, `git clang-format HEAD~` formats the last commit, you can just amend it afterward)

================
Comment at: lib/CodeGen/RegUsageInfoCollector.cpp:37
@@ +36,3 @@
+namespace llvm {
+void initializeRegUsageInfoCollectorPass(PassRegistry &);
+}
----------------
vivekvpandya wrote:
> mehdi_amini wrote:
> > Doesn't this need to be in a header and be called somewhere?
> > It's not clear to me how is this pass registered?
> Isn't this will be called by method generated due to macroINITIALIZE_PASS_BEGIN ?
If there is something in the macro expansion that makes you think it is called, please elaborate.


http://reviews.llvm.org/D20769