[PATCH] D20840: [codeview] Translate basic DITypes to CV type records

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 16:05:31 PDT 2016


majnemer added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:811-812
@@ +810,4 @@
+  case dwarf::DW_ATE_unsigned_char:
+    if (ByteSize == 1)
+      STK = SimpleTypeKind::UnsignedCharacter;
+    break;
----------------
zturner wrote:
> ```
> else if (ByteSize == 2)
>   STK = SimpleTypeKind::Character16;
> else if (ByteSize == 4)
>   STK = SimpleTypeKind::Character32;
> ```
> 
> Is there any way to distinguish `wchar_t` from `DW_ATE_unsigned_char` with `ByteSize == 2`?
The BasicType's name maybe?


http://reviews.llvm.org/D20840





More information about the llvm-commits mailing list