[PATCH] D20840: [codeview] Translate basic DITypes to CV type records

[David Majnemer via llvm-commits]

majnemer added a subscriber: majnemer.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:780
@@ +779,3 @@
+    break;
+  case dwarf::DW_ATE_decimal_float:
+  case dwarf::DW_ATE_float:
----------------
I think this is for stuff like `_Decimal64`, we shouldn't map it to floats...

The closest thing I can think of is the currency type.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:895-897
@@ +894,5 @@
+      break;
+    default:
+      IsModifier = false;
+      break;
+    }
----------------
Todo for unaligned?
Also, should we set flat?


http://reviews.llvm.org/D20840