[PATCH] D20648: Analysis pass to access profile summary info

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 15:49:28 PDT 2016


eraman added a comment.

I'll address the rest of your comments and update the patch


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:44
@@ +43,3 @@
+  };
+  auto It = std::find_if(DS.begin(), DS.end(), FindPercentile);
+  // The required percentile has to match one of the percentiles in the
----------------
vsk wrote:
> Why not a lower_bound? That should be faster, and it adds a bit of flexibility, I think.
If we want the flexibility of not specifying an exact percentile, won't nearest entry (minimum difference) be better than lower_bound? 


http://reviews.llvm.org/D20648





More information about the llvm-commits mailing list