[PATCH] D20648: Analysis pass to access profile summary info

[Vedant Kumar via llvm-commits]

vsk added a comment.

Ah ok, I think I understand the *CountPercentiles now. Just two more nits.


================
Comment at: lib/Passes/PassBuilder.cpp:71
@@ -70,2 +70,3 @@
 #include "llvm/Transforms/Scalar/GVN.h"
+#include "llvm/Transforms/Scalar/GuardWidening.h"
 #include "llvm/Transforms/Scalar/LoopRotation.h"
----------------
This change should be left out of this patch.

================
Comment at: test/Analysis/ProfileSummary/basic.ll:5
@@ +4,3 @@
+; CHECK-LABEL: callee1 :hot
+  %x1 = add i32 %x, 1
+  %x2 = add i32 %x1, 1
----------------
It doesn't seem like the contents of these function bodies affect the test. Could you minimize them?


http://reviews.llvm.org/D20648