[lld] r270963 - --threads is a flag, not a number

[David Blaikie via llvm-commits]

Perhaps renaming it to --multithreaded? or --parallel? (or some toher
similar name - perhaps there's precedent/inspiration in the existing flag
name for similar behavior in other (LLVM or non-LLVM) tools?)

On Thu, May 26, 2016 at 9:30 PM, Sean Silva via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: silvas
> Date: Thu May 26 23:30:27 2016
> New Revision: 270963
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270963&view=rev
> Log:
> --threads is a flag, not a number
>
> We would previously accept `--threads=4`, but this option just turns on
> threading and does not specify a number of threads.
>
> I ran into this by accident because I was passing `--threads=<n>` but
> the number didn't seem to affect anything.
>
> Modified:
>     lld/trunk/ELF/Options.td
>
> Modified: lld/trunk/ELF/Options.td
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td?rev=270963&r1=270962&r2=270963&view=diff
>
> ==============================================================================
> --- lld/trunk/ELF/Options.td (original)
> +++ lld/trunk/ELF/Options.td Thu May 26 23:30:27 2016
> @@ -150,7 +150,7 @@ def strip_debug : Flag<["--"], "strip-de
>  def sysroot : Joined<["--"], "sysroot=">,
>    HelpText<"Set the system root">;
>
> -def threads : Joined<["--"], "threads">;
> +def threads : Flag<["--"], "threads">;
>
>  def trace: Flag<["--"], "trace">,
>    HelpText<"Print the names of the input files">;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160526/e6f3302d/attachment.html>