<div dir="ltr">Perhaps renaming it to --multithreaded? or --parallel? (or some toher similar name - perhaps there's precedent/inspiration in the existing flag name for similar behavior in other (LLVM or non-LLVM) tools?)</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 26, 2016 at 9:30 PM, Sean Silva via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: silvas<br>
Date: Thu May 26 23:30:27 2016<br>
New Revision: 270963<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=270963&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=270963&view=rev</a><br>
Log:<br>
--threads is a flag, not a number<br>
<br>
We would previously accept `--threads=4`, but this option just turns on<br>
threading and does not specify a number of threads.<br>
<br>
I ran into this by accident because I was passing `--threads=<n>` but<br>
the number didn't seem to affect anything.<br>
<br>
Modified:<br>
    lld/trunk/ELF/Options.td<br>
<br>
Modified: lld/trunk/ELF/Options.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td?rev=270963&r1=270962&r2=270963&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td?rev=270963&r1=270962&r2=270963&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Options.td (original)<br>
+++ lld/trunk/ELF/Options.td Thu May 26 23:30:27 2016<br>
@@ -150,7 +150,7 @@ def strip_debug : Flag<["--"], "strip-de<br>
 def sysroot : Joined<["--"], "sysroot=">,<br>
   HelpText<"Set the system root">;<br>
<br>
-def threads : Joined<["--"], "threads">;<br>
+def threads : Flag<["--"], "threads">;<br>
<br>
 def trace: Flag<["--"], "trace">,<br>
   HelpText<"Print the names of the input files">;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>