[PATCH] D20584: [RewriteStatepointsForGC] All constant should have null base pointer

[Igor Laevsky via llvm-commits]

igor-laevsky created this revision.
igor-laevsky added reviewers: mjacob, sanjoy, reames.
igor-laevsky added a subscriber: llvm-commits.
Herald added a subscriber: sanjoy.

Currently we consider that each constant has itself as a base value. I.e "base(const) = const". This introduces couple of problems when we are trying to avoid reporting constants in statepoint live sets:

1. When querying "base( phi(const1, const2) )" we will get "phi(const1, const2)" as a base pointer. Since it's not a constant we will record it in a stack map. However on practice we don't want this to happen (constant are never relocated).
2. base( phi(const, gc ptr) ) = phi( const, base(gc ptr) ). This particular case imposes challenge on our runtime - we don't expect to see constant base pointers other than null.

This problems can be avoided by treating all constant as if they were derived from null pointer base. I.e in a first case we will not include constant pointer in a stack map at all. In a second case we will get "phi(null, base(gc ptr))" as a base pointer which is a lot more convenient.

@Manuel, I understand that your use case of the RS4GC is sensitive to how we handle global variables. Could you please take a look so that this change doesn't bring you any problems?

http://reviews.llvm.org/D20584

Files:
  lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
  test/Transforms/RewriteStatepointsForGC/base-pointers-12.ll
  test/Transforms/RewriteStatepointsForGC/base-pointers-13.ll
  test/Transforms/RewriteStatepointsForGC/base-vector.ll
  test/Transforms/RewriteStatepointsForGC/constants.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20584.58275.patch
Type: text/x-patch
Size: 9631 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160524/6c1bf60f/attachment.bin>