[PATCH] D20314: Move ProfileSummary to IR

[Xinliang David Li via llvm-commits]

On Tue, May 17, 2016 at 11:56 AM, Vedant Kumar <vsk at apple.com> wrote:

> vsk added inline comments.
>
> ================
> Comment at: include/llvm/IR/ProfileSummary.h:2
> @@ +1,3 @@
> +//===-- ProfileSummary.h - Profile summary data structure. ------*- C++
> -*-===//
> +//
> +//                     The LLVM Compiler Infrastructure
> ----------------
> davidxl wrote:
> > Why is this not suitable to be in Support?
> Nothing in Support uses llvm::{Metadata, LLVMContext}, so it would seem a
> bit out of place to me there.
>


Ok -- that is what I missed.

thanks,

David

>
> ================
> Comment at: lib/ProfileData/InstrProfReader.cpp:620
> @@ +619,3 @@
> +    // FIXME: This only computes an empty summary. Need to call addRecord
> for
> +    // all
> +    // InstrProfRecords to get the correct summary.
> ----------------
> nit, formatting
>
>
> http://reviews.llvm.org/D20314
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160517/b9baf568/attachment.html>