[PATCH] D20314: Move ProfileSummary to IR
Vedant Kumar via llvm-commits
llvm-commits at lists.llvm.org
Tue May 17 11:56:06 PDT 2016
vsk added inline comments.
================
Comment at: include/llvm/IR/ProfileSummary.h:2
@@ +1,3 @@
+//===-- ProfileSummary.h - Profile summary data structure. ------*- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
----------------
davidxl wrote:
> Why is this not suitable to be in Support?
Nothing in Support uses llvm::{Metadata, LLVMContext}, so it would seem a bit out of place to me there.
================
Comment at: lib/ProfileData/InstrProfReader.cpp:620
@@ +619,3 @@
+ // FIXME: This only computes an empty summary. Need to call addRecord for
+ // all
+ // InstrProfRecords to get the correct summary.
----------------
nit, formatting
http://reviews.llvm.org/D20314
More information about the llvm-commits
mailing list