[PATCH] D20282: Implement RAS extensions for ARMv8.2-A

Roger Ferrer Ibanez via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 03:05:41 PDT 2016


rogfer01 added inline comments.

================
Comment at: include/llvm/Support/ARMTargetParser.def:127
@@ -126,2 +126,3 @@
 ARM_ARCH_EXT_NAME("fp16",     AEK_FP16,     "+fullfp16",  "-fullfp16")
+ARM_ARCH_EXT_NAME("ras",      AEK_RAS,      "+rasext", "-rasext")
 ARM_ARCH_EXT_NAME("os",       AEK_OS,       nullptr,  nullptr)
----------------
t.p.northover wrote:
> I'd just use "+/-ras". The "ext" is a bit redundant.
Unfortunately "ras" is already taken for an unrelated thing in the ARM target. And it seems to conflict with this. Doable but I'm afraid the patch will be slightly noisier.


http://reviews.llvm.org/D20282





More information about the llvm-commits mailing list