[PATCH] D20282: Implement RAS extensions for ARMv8.2-A

[Tim Northover via llvm-commits]

t.p.northover added a comment.

This mostly looks reasonable, just one consistency niggle with the naming:


================
Comment at: include/llvm/Support/ARMTargetParser.def:127
@@ -126,2 +126,3 @@
 ARM_ARCH_EXT_NAME("fp16",     AEK_FP16,     "+fullfp16",  "-fullfp16")
+ARM_ARCH_EXT_NAME("ras",      AEK_RAS,      "+rasext", "-rasext")
 ARM_ARCH_EXT_NAME("os",       AEK_OS,       nullptr,  nullptr)
----------------
I'd just use "+/-ras". The "ext" is a bit redundant.


http://reviews.llvm.org/D20282