[PATCH] D20271: [TM] Start collapsing LLVMTargetMachine into TargetMachine

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 13:28:01 PDT 2016


On 16 May 2016 at 16:24, Davide Italiano <dccitaliano at gmail.com> wrote:
> davide added inline comments.
>
> ================
> Comment at: lib/Target/TargetMachine.cpp:151
> @@ -150,3 +151,3 @@
>
>  TargetIRAnalysis TargetMachine::getTargetIRAnalysis() {
>    return TargetIRAnalysis([this](const Function &F) {
> ----------------
> rafael wrote:
>> Can you change this to be non-virtual now?
> Not entirely sure because PPC and Hexagon still override that? Can we somehow avoid it?
> ```

Oh, it is perfectly fine to leave it as is. I just thought you had
forgotten about it.

LGTM assuming a BUILD_SHARED_LIBS build works.


Cheers,
Rafael


More information about the llvm-commits mailing list