[PATCH] D20271: [TM] Start collapsing LLVMTargetMachine into TargetMachine
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Mon May 16 13:24:46 PDT 2016
davide added inline comments.
================
Comment at: lib/Target/TargetMachine.cpp:151
@@ -150,3 +151,3 @@
TargetIRAnalysis TargetMachine::getTargetIRAnalysis() {
return TargetIRAnalysis([this](const Function &F) {
----------------
rafael wrote:
> Can you change this to be non-virtual now?
Not entirely sure because PPC and Hexagon still override that? Can we somehow avoid it?
```
../lib/Target/PowerPC/PPCTargetMachine.h:48:42: error: only virtual member functions can be marked 'override'
TargetIRAnalysis getTargetIRAnalysis() override;
^~~~~~~~
```
http://reviews.llvm.org/D20271
More information about the llvm-commits
mailing list