[PATCH] D20270: libc++abi: build with -fvisibility=default

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Sat May 14 15:19:53 PDT 2016


compnerd added a comment.

Hmm, actually, investigating this further, it seems that libc++abi already has an implementation of `std::set_terminate`, `std::set_unexpected`, `std::set_new_handler`, `std::get_new_handler`.  Why not add `std::get_terminate`, `std::get_unexpected` and not expose the storage?  Im not sure how the bindings for these currently works.

I don't believe OS X defaults to two-level namespaces, so the binding there should still resolve if we were to move these.  ELF doesn't support two-level namespaces, so again, we should be safe there.  That leaves COFF, which I don't believe has a stable ABI, so we should be able to get away with this for now.

Furthermore, to support this move, there is prior art supporting this model.  libcxxrt and libsupc++ both provide these interfaces.


Repository:
  rL LLVM

http://reviews.llvm.org/D20270





More information about the llvm-commits mailing list