[PATCH] D20270: libc++abi: build with -fvisibility=default

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Sat May 14 15:05:43 PDT 2016


compnerd added a comment.

Okay, so the differences are caused by the data definitions which hold the current allocator (`std::set_new_handler`), terminator (`std::set_terminate`), and unexpected exception handler (`std::set_unexpected`).  We could either move those three functions in libc++abi (ABI break) or export the data symbols :-(.  Doing so however means that users can directly (and therefore unsafely!) access the pointer in a multithreaded environment.  The accessors in the `std` namespace are just atomic accessors to the pointers.  Ill upload a new version of the patch which marks the data symbols for export for now.


Repository:
  rL LLVM

http://reviews.llvm.org/D20270





More information about the llvm-commits mailing list