[PATCH] D20122: [codeview] Add type stream merging prototype

[Reid Kleckner via llvm-commits]

rnk added inline comments.

================
Comment at: lib/DebugInfo/CodeView/TypeRecord.cpp:45-48
@@ +44,6 @@
+  bool Success = true;
+  Success &= remapIndex(IndexMap, ReturnType);
+  Success &= remapIndex(IndexMap, ClassType);
+  Success &= remapIndex(IndexMap, ThisType);
+  Success &= remapIndex(IndexMap, ArgumentList);
+  return Success;
----------------
zturner wrote:
> Will this short circuit if anything fails?  Perhaps you should write `Success = Success && remapIndex(IndexMap, ReturnType)` etc.
The idea is that it won't short circuit. It will remap all the indices to the "untranslated" index, and then you can decide if you want to warn the user that some of the input was invalid. It seemed useful in the context of writing a PDB, where some object files might be busted, but you don't want to abort the whole link.


http://reviews.llvm.org/D20122