[PATCH] D20122: [codeview] Add type stream merging prototype

[Zachary Turner via llvm-commits]

zturner added inline comments.

================
Comment at: lib/DebugInfo/CodeView/TypeRecord.cpp:45-48
@@ +44,6 @@
+  bool Success = true;
+  Success &= remapIndex(IndexMap, ReturnType);
+  Success &= remapIndex(IndexMap, ClassType);
+  Success &= remapIndex(IndexMap, ThisType);
+  Success &= remapIndex(IndexMap, ArgumentList);
+  return Success;
----------------
Will this short circuit if anything fails?  Perhaps you should write `Success = Success && remapIndex(IndexMap, ReturnType)` etc.


http://reviews.llvm.org/D20122