[PATCH] D20258: IR: Introduce can_omit_from_dynsym attribute.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 14:46:09 PDT 2016


On 13 May 2016 at 17:44, David Majnemer <david.majnemer at gmail.com> wrote:
> majnemer added a subscriber: majnemer.
> majnemer added a comment.
>
> In http://reviews.llvm.org/D20258#430070, @rafael wrote:
>
>> As for naming, I would probably name it after what it checks, not what
>>  it is currently used for.
>>
>> How about making the attribute be just "address_not_used_in_module"?
>>  The other properties (like being linkonce_odr) are easy to check
>>  without having to walk all uses.
>>
>> Should the verifier check if this the property is invalidly set?
>>
>> Cheers,
>> Rafael
>
>
> How about `unnamed_addr_in_module`?

I like it, thanks.

Cheers,
Rafael


More information about the llvm-commits mailing list