[PATCH] D20234: Do not assume InstAlias operands appear after a blank
Roger Ferrer Ibanez via llvm-commits
llvm-commits at lists.llvm.org
Fri May 13 05:11:23 PDT 2016
rogfer01 created this revision.
rogfer01 added a reviewer: stoklund.
rogfer01 added a subscriber: llvm-commits.
Herald added a subscriber: aemerson.
AsmWriterEmitter.cpp assumes that all operands of a printed alias
will appear after a blank. This assumption does not hold in the ARM
target.
http://reviews.llvm.org/D20234
Files:
utils/TableGen/AsmWriterEmitter.cpp
Index: utils/TableGen/AsmWriterEmitter.cpp
===================================================================
--- utils/TableGen/AsmWriterEmitter.cpp
+++ utils/TableGen/AsmWriterEmitter.cpp
@@ -1005,13 +1005,14 @@
// Code that prints the alias, replacing the operands with the ones from the
// MCInst.
O << " unsigned I = 0;\n";
- O << " while (AsmString[I] != ' ' && AsmString[I] != '\t' &&\n";
- O << " AsmString[I] != '\\0')\n";
+ O << " while (AsmString[I] != ' ' && AsmString[I] != '\\t' &&\n";
+ O << " AsmString[I] != '$' && AsmString[I] != '\\0')\n";
O << " ++I;\n";
O << " OS << '\\t' << StringRef(AsmString, I);\n";
O << " if (AsmString[I] != '\\0') {\n";
- O << " OS << '\\t';\n";
+ O << " if (AsmString[I] == ' ' || AsmString[I] == '\\t')";
+ O << " OS << '\\t';\n";
O << " do {\n";
O << " if (AsmString[I] == '$') {\n";
O << " ++I;\n";
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20234.57161.patch
Type: text/x-patch
Size: 936 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160513/1d0d3637/attachment.bin>
More information about the llvm-commits
mailing list