[PATCH] D20115: Loop unroller: set thresholds for optsize and minsize functions to zero

[Hans Wennborg via llvm-commits]

hans added inline comments.

================
Comment at: test/Transforms/LoopUnroll/unroll-opt-attribute.ll:7-10
@@ -6,6 +6,6 @@
 
-; This test shows that with optsize attribute, the loop is unrolled
-; according to the specified unroll factor.
+; This test shows that the loop is unrolled according to the specified
+; unroll factor.
 
-define void @Test1() nounwind optsize {
+define void @Test1() nounwind {
 entry:
----------------
rnk wrote:
> mamai wrote:
> > This test should not need to be modified if the #pragma unroll still works in /Os... The -unroll-count=4 should simulate the unroll pragma, and therefor the loop should be unrolled even if the optsize attribute is there.
> Sounds like the LLVM pass is misbehaving then, and we should revert the clang side change to enable the loop unroller until this is addressed in LLVM.
I'm looking into it. I'm not sure the -unroll-count flag and the pragma do the same thing. Maybe this is easy to fix..


http://reviews.llvm.org/D20115