[PATCH] D20115: Loop unroller: set thresholds for optsize and minsize functions to zero

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 10:53:03 PDT 2016


rnk added inline comments.

================
Comment at: test/Transforms/LoopUnroll/unroll-opt-attribute.ll:7-10
@@ -6,6 +6,6 @@
 
-; This test shows that with optsize attribute, the loop is unrolled
-; according to the specified unroll factor.
+; This test shows that the loop is unrolled according to the specified
+; unroll factor.
 
-define void @Test1() nounwind optsize {
+define void @Test1() nounwind {
 entry:
----------------
mamai wrote:
> This test should not need to be modified if the #pragma unroll still works in /Os... The -unroll-count=4 should simulate the unroll pragma, and therefor the loop should be unrolled even if the optsize attribute is there.
Sounds like the LLVM pass is misbehaving then, and we should revert the clang side change to enable the loop unroller until this is addressed in LLVM.


http://reviews.llvm.org/D20115





More information about the llvm-commits mailing list