[PATCH] D20026: Parse each module's module info stream
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Fri May 6 14:58:26 PDT 2016
ruiu added inline comments.
================
Comment at: lib/DebugInfo/PDB/Raw/ByteStream.cpp:27-29
@@ -26,5 +26,5 @@
void ByteStream::reset() {
- if (Owned)
+ if (Owned && Data.size() > 0)
delete[] Data.data();
Owned = false;
Data = MutableArrayRef<uint8_t>();
----------------
Why do you manage ownership by hand instead of unique_ptr?
http://reviews.llvm.org/D20026
More information about the llvm-commits
mailing list