[PATCH] D20026: Parse each module's module info stream

[Reid Kleckner via llvm-commits]

rnk added a comment.

All of this code is still dead. Are you sure you don't want to hold off on committing this until some kind of byte dumping is hooked up from llvm-pdbdump?


================
Comment at: include/llvm/DebugInfo/PDB/Raw/ModStream.h:10
@@ +9,3 @@
+
+#ifndef LLVM_DEBUGINFO_PDB_RAW_PDBMODSTREAM_H
+#define LLVM_DEBUGINFO_PDB_RAW_PDBMODSTREAM_H
----------------
Wouldn't the header guard be named ...RAW_MODSTREAM_H?

================
Comment at: lib/DebugInfo/PDB/CMakeLists.txt:36
@@ -34,3 +35,3 @@
   Raw/PDBFile.cpp
   Raw/DbiStream.cpp
   Raw/InfoStream.cpp
----------------
consider sorting these at some point

================
Comment at: lib/DebugInfo/PDB/Raw/ModStream.cpp:31
@@ +30,3 @@
+  if (C11Size > 0 && C13Size > 0)
+    return llvm::make_error<RawError>(raw_error_code::corrupt_file,
+                                      "Module has both C11 and C13 line info");
----------------
Same thought as before about adding `errorCorruptFile` or something.


http://reviews.llvm.org/D20026