[lld] r268743 - [ELF][MIPS] Reduce code duplication. NFC

[Rafael Espíndola via llvm-commits]

and more awesome :-)

Thanks for the cleanups!


On 6 May 2016 at 11:02, Simon Atanasyan via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: atanasyan
> Date: Fri May  6 10:02:54 2016
> New Revision: 268743
>
> URL: http://llvm.org/viewvc/llvm-project?rev=268743&view=rev
> Log:
> [ELF][MIPS] Reduce code duplication. NFC
>
> Modified:
>     lld/trunk/ELF/Target.cpp
>
> Modified: lld/trunk/ELF/Target.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=268743&r1=268742&r2=268743&view=diff
> ==============================================================================
> --- lld/trunk/ELF/Target.cpp (original)
> +++ lld/trunk/ELF/Target.cpp Fri May  6 10:02:54 2016
> @@ -1472,17 +1472,17 @@ void MipsTargetInfo<ELFT>::relocateOne(u
>    // fallthrough
>    case R_MIPS_CALL16:
>    case R_MIPS_GOT_OFST:
> +  case R_MIPS_LO16:
> +  case R_MIPS_PCLO16:
>      writeMipsLo16<E>(Loc, Val);
>      break;
>    case R_MIPS_HI16:
> +  case R_MIPS_PCHI16:
>      writeMipsHi16<E>(Loc, Val);
>      break;
>    case R_MIPS_JALR:
>      // Ignore this optimization relocation for now
>      break;
> -  case R_MIPS_LO16:
> -    writeMipsLo16<E>(Loc, Val);
> -    break;
>    case R_MIPS_PC16:
>      applyMipsPcReloc<E, 16, 2>(Loc, Type, Val);
>      break;
> @@ -1498,12 +1498,6 @@ void MipsTargetInfo<ELFT>::relocateOne(u
>    case R_MIPS_PC32:
>      applyMipsPcReloc<E, 32, 0>(Loc, Type, Val);
>      break;
> -  case R_MIPS_PCHI16:
> -    writeMipsHi16<E>(Loc, Val);
> -    break;
> -  case R_MIPS_PCLO16:
> -    writeMipsLo16<E>(Loc, Val);
> -    break;
>    case R_MIPS_TLS_DTPREL_HI16:
>      writeMipsHi16<E>(Loc, Val - DTPOffset);
>      break;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits